Messages in this thread | | | Subject | Re: [RFC] Question about freeing of resource in 'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c' | From | Christophe JAILLET <> | Date | Tue, 20 Dec 2016 06:44:04 +0100 |
| |
Le 19/12/2016 à 14:54, Vladimir Zapolskiy a écrit : > Functionally it looks good, I have two comments though. > 1) you don't need to revert 151b8c5ba1eb, the commit is a proper fix > per se but incomplete, please add your change on top of it, > > 2) minimizing the lines of code by removing duplicates is always good, > so here a better and complete fix will be like the following one: > Hi,
thanks for the feedback and comments. Patch submitted.
CJ
| |