Messages in this thread | | | Subject | Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming | From | Giuseppe CAVALLARO <> | Date | Fri, 2 Dec 2016 09:44:48 +0100 |
| |
Hello Corentin
patches look ok, I just wonder if you tested it in case of the stmmac is connected to a transceiver. Let me consider it a critical part of the driver to properly work.
Regards Peppe
On 12/1/2016 4:19 PM, Corentin Labbe wrote: > This patch simply rename regValue to value, like it was named in other > mdio functions. > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > index e3216e5..6796c28 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > @@ -83,14 +83,14 @@ static int stmmac_mdio_read(struct mii_bus *bus, int phyaddr, int phyreg) > unsigned int mii_data = priv->hw->mii.data; > > int data; > - u16 regValue = (((phyaddr << 11) & (0x0000F800)) | > + u16 value = (((phyaddr << 11) & (0x0000F800)) | > ((phyreg << 6) & (0x000007C0))); > - regValue |= MII_BUSY | ((priv->clk_csr & 0xF) << 2); > + value |= MII_BUSY | ((priv->clk_csr & 0xF) << 2); > > if (stmmac_mdio_busy_wait(priv->ioaddr, mii_address)) > return -EBUSY; > > - writel(regValue, priv->ioaddr + mii_address); > + writel(value, priv->ioaddr + mii_address); > > if (stmmac_mdio_busy_wait(priv->ioaddr, mii_address)) > return -EBUSY; >
| |