lkml.org 
[lkml]   [2016]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] net: stmmac: avoid Camelcase naming
From
Date
Hello Corentin

patches look ok, I just wonder if you tested it in case of
the stmmac is connected to a transceiver. Let me consider it
a critical part of the driver to properly work.

Regards
Peppe

On 12/1/2016 4:19 PM, Corentin Labbe wrote:
> This patch simply rename regValue to value, like it was named in other
> mdio functions.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> index e3216e5..6796c28 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> @@ -83,14 +83,14 @@ static int stmmac_mdio_read(struct mii_bus *bus, int phyaddr, int phyreg)
> unsigned int mii_data = priv->hw->mii.data;
>
> int data;
> - u16 regValue = (((phyaddr << 11) & (0x0000F800)) |
> + u16 value = (((phyaddr << 11) & (0x0000F800)) |
> ((phyreg << 6) & (0x000007C0)));
> - regValue |= MII_BUSY | ((priv->clk_csr & 0xF) << 2);
> + value |= MII_BUSY | ((priv->clk_csr & 0xF) << 2);
>
> if (stmmac_mdio_busy_wait(priv->ioaddr, mii_address))
> return -EBUSY;
>
> - writel(regValue, priv->ioaddr + mii_address);
> + writel(value, priv->ioaddr + mii_address);
>
> if (stmmac_mdio_busy_wait(priv->ioaddr, mii_address))
> return -EBUSY;
>

\
 
 \ /
  Last update: 2016-12-02 09:45    [W:0.504 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site