Messages in this thread | | | From | Ricardo Ribalda Delgado <> | Date | Fri, 2 Dec 2016 11:52:17 +0100 | Subject | Re: [PATCH v8] mtd: spi-nor: Add support for S3AN spi-nor devices |
| |
Hi Marek
On Thu, Dec 1, 2016 at 7:11 PM, Marek Vasut <marek.vasut@gmail.com> wrote: > On 12/01/2016 06:52 PM, Ricardo Ribalda Delgado wrote: >> Hi Marek > > Hi, > >> Thanks for your review >> >> On Thu, Dec 1, 2016 at 5:05 PM, Marek Vasut <marek.vasut@gmail.com> wrote: >>> >>> On 11/24/2016 05:56 PM, Ricardo Ribalda Delgado wrote: >> >>>> +#define SPI_S3AN BIT(10) /* >>>> + * Xilinx Spartan 3AN In-System Flash >>>> + * (MFR cannot be used for probing >>>> + * because it has the same value as >>>> + * ATMEL flashes) >>>> + */ >>> >>> I have possibly off-topic question. Altera has something very similar -- >>> EPCS/EPCQ flash which cannot be detected using standard READID . >>> Would this patch help with supporting those degenerate flashes too? >>> >>>> }; >>>> >> >> I dont know, but I love the term degenerated flash, please let me use it :) > > Hehe. It'd be great to know whether we don't have a possibility for a > generic usecase here. Can you briefly check that ?
I have taken a brief look to https://www.altera.com/content/dam/altera-www/global/en_US/pdfs/literature/hb/cfg/cfg_cf52012.pdf
and they seem different enough to not reuse the flag :(.
>> I guess they are using some bits reserved to ECC for data and that way >> you can squeeze some bits for user data. > > OK, comment could help clarify this, so please add one.
Will send a v9
Thanks!
| |