Messages in this thread | | | From | Madalin-Cristian Bucur <> | Subject | RE: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[] | Date | Mon, 19 Dec 2016 16:07:45 +0000 |
| |
> From: David Miller [mailto:davem@davemloft.net] > Sent: Monday, December 19, 2016 5:37 PM > > From: Madalin Bucur <madalin.bucur@nxp.com> > Date: Mon, 19 Dec 2016 11:22:20 +0200 > > > The fsl/fman drivers will use of_platform_populate() on all > > supported platforms. > > > > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> > > It seems that this creates a failure point between patches #2 and > #3. If the cases handled by this "fsl,fman" entry are only afterwards > covered by the of_platform_populate() code added in patch #3 then you > cannot split these two changes up like this. > > The two changes must be done at the same time, otherwise probing will > fail for some people between patches #2 and #3.
You are right, that will happen. I was not convinced these need to be merged due to the different places they touch. I'll send a v3.
| |