Messages in this thread | | | Date | Sun, 18 Dec 2016 19:24:46 +0000 | From | Afonso Bordado <> | Subject | Re: [PATCH] staging: emxx_udc: Fix CamelCase styling issue |
| |
> Instead of merely converting Hungarian CamelCase to lowercase > with underscores where word transitions occurred, try reading > the code and making sense of what it does to perhaps find a > better variable name instead. Maybe eliminate the variable > altogether. > > iWordLength could be reads or numreads
Ok!
> btw: what happens if length is not a multiple of sizeof(u32)?
Reading over the code (something I should have done the first time) it seems that it rounds down, not doing the full transfer, and EP0_out_OverBytes handles the remaining transfer.
Since EP0_out_OverBytes is only called once and for this purpose would it be perferable to do that on EP0_out_PIO?
> nret is more commonly ret > p_buf is also not common linux naming, buf is more common.
Ok!
| |