lkml.org 
[lkml]   [2016]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 2/2] mfd: axp20x: Fix axp288 volatile ranges
    From
    Date
    Hi,

    On 17-12-16 16:12, Chen-Yu Tsai wrote:
    > On Sat, Dec 17, 2016 at 4:09 AM, Hans de Goede <hdegoede@redhat.com> wrote:
    >> The axp288 pmic has a lot more volatile registers then we were
    >> listing in axp288_volatile_ranges, fix this.
    >>
    >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    >
    > Acked-by: Chen-Yu Tsai <wens@csie.org>

    Thank you.

    > FYI, if you're going to add support for the battery charger detection
    > module later,

    That driver is already in mainline, but like the other axp288 drivers
    it needs some love to actual successfully probe and work, I've a set
    of patches for ready for this, since I've been successfully testing
    them the last few days I guess I might as well send them now,
    so expect some patches for this soon :)

    you would need to add the remaining AXP288_BC_* registers
    > to the writable table.

    The writeable table contains:
    regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ6_STATE),

    Which already includes all of the BC registers.

    Regards,

    Hans

    \
     
     \ /
      Last update: 2016-12-18 20:19    [W:4.199 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site