lkml.org 
[lkml]   [2016]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 02/14] sparc64: add new fields to mmu context for shared context support
Hi Mike

> diff --git a/arch/sparc/include/asm/mmu_context_64.h b/arch/sparc/include/asm/mmu_context_64.h
> index b84be67..d031799 100644
> --- a/arch/sparc/include/asm/mmu_context_64.h
> +++ b/arch/sparc/include/asm/mmu_context_64.h
> @@ -35,15 +35,15 @@ void __tsb_context_switch(unsigned long pgd_pa,
> static inline void tsb_context_switch(struct mm_struct *mm)
> {
> __tsb_context_switch(__pa(mm->pgd),
> - &mm->context.tsb_block[0],
> + &mm->context.tsb_block[MM_TSB_BASE],
> #if defined(CONFIG_HUGETLB_PAGE) || defined(CONFIG_TRANSPARENT_HUGEPAGE)
> - (mm->context.tsb_block[1].tsb ?
> - &mm->context.tsb_block[1] :
> + (mm->context.tsb_block[MM_TSB_HUGE].tsb ?
> + &mm->context.tsb_block[MM_TSB_HUGE] :
> NULL)
> #else
> NULL
> #endif
> - , __pa(&mm->context.tsb_descr[0]));
> + , __pa(&mm->context.tsb_descr[MM_TSB_BASE]));
> }
>
This is a nice cleanup that has nothing to do with your series.
Could you submit this as a separate patch so we can get it applied.

This is the only place left where the array index for tsb_block
and tsb_descr uses hardcoded values. And it would be good to get
rid of these.

Sam

\
 
 \ /
  Last update: 2016-12-17 08:38    [W:2.106 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site