Messages in this thread | | | Subject | Re: [PATCH] ubifs: add CONFIG_BLOCK dependency for encryption | From | Richard Weinberger <> | Date | Fri, 16 Dec 2016 10:26:35 +0100 |
| |
Arnd,
On 16.12.2016 09:42, Arnd Bergmann wrote: > This came up during the v4.10 merge window: > > warning: (UBIFS_FS_ENCRYPTION) selects FS_ENCRYPTION which has unmet direct dependencies (BLOCK) > fs/crypto/crypto.c: In function 'fscrypt_zeroout_range': > fs/crypto/crypto.c:355:9: error: implicit declaration of function 'bio_alloc';did you mean 'd_alloc'? [-Werror=implicit-function-declaration] > bio = bio_alloc(GFP_NOWAIT, 1); > > The easiest way out is to limit UBIFS_FS_ENCRYPTION to configurations > that also enable BLOCK.
Thanks for the fix! I'll queue this for -rc2.
In the long-run I'd like to remove the CONFIG_BLOCK dependency from fs/crypto/crypto.c since UBIFS does not use the block related functions at all.
Thanks, //richard
| |