Messages in this thread | | | Subject | Re: [PATCH] drivers: staging: comedi: fix function prototypes | From | Ian Abbott <> | Date | Thu, 15 Dec 2016 11:46:31 +0000 |
| |
On 14/12/16 16:14, Hartley Sweeten wrote: > On December 14, 2016 6:42 AM, Piotr Gregor wrote: >> Add names of parameters to function prototypes in comedi PCI. >> Checkpatch reports now no errors. >> >> Signed-off-by: Piotr Gregor <piotrgregor@rsyncme.org> >> --- >> drivers/staging/comedi/comedi_pci.h | 18 ++++++++++-------- >> 1 file changed, 10 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h >> index 4005cc9..7dfd892 100644 >> --- a/drivers/staging/comedi/comedi_pci.h >> +++ b/drivers/staging/comedi/comedi_pci.h >> @@ -34,18 +34,20 @@ >> #define PCI_VENDOR_ID_RTD 0x1435 >> #define PCI_VENDOR_ID_HUMUSOFT 0x186c >> >> -struct pci_dev *comedi_to_pci_dev(struct comedi_device *); >> +struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev); > > For the function prototypes I prefer no names for the "pointer" parameters. > > The "struct foo *" declaration is just as clear as "struct foo *bar".
Maybe, but checkpatch.pl doesn't agree (not since commit ca0d8929e75ab1f860f61208d46955f280a1b05e anyway)!
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |