Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 14 Dec 2016 09:58:53 +0100 | Subject | Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on |
| |
On Wed, Dec 14, 2016 at 2:18 AM, Max <jbires@google.com> wrote: > Without a bool string present, using "# CONFIG_DEVPORT is not set" in > defconfig files would not actually unset devport. This ensured that > /dev/port was always on, but there are reasons a user may wish to disable > it (smaller kernel, attack surface reduction) if it's not being used. Adding > a message here in order to make this user visible. > > Signed-off-by: Max Bires <jbires@google.com> > --- > drivers/char/Kconfig | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig > index 7ad3127..e8fc493 100644 > > --- a/drivers/char/Kconfig > +++ b/drivers/char/Kconfig > @@ -589,10 +589,13 @@ config TELCLOCK > controlling the behavior of this hardware. > > config DEVPORT > - bool > + bool "/dev/port character device"
bool "/dev/port character device" if EXPERT?
> depends on !M68K > depends on ISA || PCI > default y > + help > + Say Y here if you want to support the /dev/port device. The > + /dev/port device is similar to /dev/mem, but for I/O ports.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |