lkml.org 
[lkml]   [2016]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] perf tools: ignore zombie process for user profile
Date


.
> Em Wed, Dec 14, 2016 at 06:26:02PM +0000, Liang, Kan escreveu:
> > > On Wed, Dec 14, 2016 at 12:48:05PM -0500, kan.liang@intel.com wrote:
> > > > From: Kan Liang <kan.liang@intel.com> Zombie process is dead
> > > > process. It is meaningless to profile it.
> > > > It's better to ignore it for user profile.
>
> > > I recently posted different patch for same issue:
> > > http://marc.info/?l=linux-kernel&m=148153895827359&w=2
>
> > The change as below make me confuse.
> > + /* The system wide setup does not work with threads. */
> > + if (!evsel->system_wide)
> > + return false;
> > It looks the meaning of the comments is inconsistent with the code.
>
> > Your original patch doesn't work well with the issue.
> > But if I change the above code as below, the issue is fixed.
> > if (evsel->system_wide)
> > return false;
>
> yeah, Namhyung noticed that, Jiri sent a fixed patch, I have it already in my
> perf/core branch.
>

That's great. Then Jiri's patch would work on my case.
Please ignore this patch.

Thanks,
Kan

\
 
 \ /
  Last update: 2016-12-14 20:20    [W:0.043 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site