Messages in this thread | | | Subject | Re: [PATCH] IB/mlx4: avoid a -Wmaybe-uninitialize warning | From | Doug Ledford <> | Date | Wed, 14 Dec 2016 12:13:43 -0500 |
| |
On 10/25/2016 12:16 PM, Arnd Bergmann wrote: > There is an old warning about mlx4_SW2HW_EQ_wrapper on x86: > > ethernet/mellanox/mlx4/resource_tracker.c: In function ‘mlx4_SW2HW_EQ_wrapper’: > ethernet/mellanox/mlx4/resource_tracker.c:3071:10: error: ‘eq’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > > The problem here is that gcc won't track the state of the variable > across a spin_unlock. Moving the assignment out of the lock is > safe here and avoids the warning. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied.
-- Doug Ledford <dledford@redhat.com> GPG Key ID: 0E572FDD
[unhandled content-type:application/pgp-signature] | |