lkml.org 
[lkml]   [2016]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set()
    On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
    > On Thursday 08 December 2016 13:36:15 Michał Kępień wrote:
    >> All calls to dell_app_wmi_led_set() have been replaced with direct
    >> calls to dell_micmute_led_set(), so the former can be safely removed
    >> along with its related enum.
    >>
    >> Signed-off-by: Michał Kępień <kernel@kempniu.pl>
    >
    > I would suggest to squash patches 2,3,4 into one. But I let decision to
    > alsa & led maintainers.

    I don't like the part where we are exporting something for just one
    moment. So, +1 to squashed version.

    >
    > Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup
    >
    > Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
    >
    > --
    > Pali Rohár
    > pali.rohar@gmail.com



    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2016-12-14 02:55    [W:3.662 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site