lkml.org 
[lkml]   [2016]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v2 0/3] bq24735-charger: allow gpio polling and sharing
    Date
    Hi!

    v1 -> v2 changes:
    - use poll-interval instead of ti,poll-interval-ms in the bindings
    - properly initialize the shared_lock mutex
    - don't share gpios on active low/high mismatch
    - don't regress users specifying the old ti,ac-detect-gpio form (without
    the trailing s)

    I have a board that features a couple of parallel bq24735 chargers.
    However, only one of the chargers has its ACOK pin wired to a gpio,
    the other parallel chargers are expected to just behave the same
    as the charger that has been singled out like this. Another thing
    with the board is that the gpio is not capable of generating an
    interrupt.

    This series fixes things for me (ok, the first patch was just a
    fix for a thing that initially had me confused for a bit, and is
    totally unrelated. Ignore if you want to, it's basically just churn).

    One thing that I wonder about is if anything should be done to
    prevent unloading of the instance that shares its gpio? I thought
    about adding a device_link_add() call, but am unsure if that would
    be approprite? I'm not unloading drivers at all so it's a total
    non-issue for me...

    Cheers,
    peda

    Peter Rosin (3):
    power: supply: bq24735-charger: simplify register update to stop
    charging
    power: supply: bq24735-charger: optionally poll the ac-detect gpio
    power: supply: bq24735-charger: allow chargers to share the ac-detect
    gpio

    .../bindings/power/supply/ti,bq24735.txt | 2 +
    drivers/power/supply/bq24735-charger.c | 164 ++++++++++++++++++---
    2 files changed, 148 insertions(+), 18 deletions(-)

    --
    2.1.4

    \
     
     \ /
      Last update: 2016-12-14 01:29    [W:3.775 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site