lkml.org 
[lkml]   [2016]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0
Date
Hi Sylwester,

On Tuesday 13 Dec 2016 13:38:52 Sylwester Nawrocki wrote:
> On 12/13/2016 02:58 AM, Nicholas Mc Guire wrote:
> > As this is not in atomic context and it does not seem like a critical
> > timing setting a range of 1ms allows the timer subsystem to optimize
> > the hrtimer here.
> >
> > Fixes: commit bfa8dd3a0524 ("[media] v4l: Add v4l2 subdev driver for
> > S5K6AAFX sensor") Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> > ---
>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> I'm not sure the "Fixes" tag is needed here.
>
> > Patch is against 4.9.0 (localversion-next is next-20161212)
>
> Ideally patches for the media subsystem should be normally based on
> master branch of the media tree (git://linuxtv.org/media_tree.git).

As pointed out by Ian Arkver, the datasheet states the delay should be >50µs.
Would it make sense to reduce the sleep duration to (3000, 4000) for instance
(or possibly even lower), instead of increasing it ?

--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2016-12-13 15:09    [W:0.456 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site