Messages in this thread | | | Subject | Re: [PATCH v6 3/5] ARM: dts: stm32: Add I2C1 support for STM32F429 SoC | From | Alexandre Torgue <> | Date | Tue, 13 Dec 2016 11:01:48 +0100 |
| |
Hi Cedric,
On 12/12/2016 05:15 PM, M'boumba Cedric Madianga wrote: > Signed-off-by: Patrice Chotard <patrice.chotard@st.com> > Signed-off-by: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
Please Add a commit message.
> --- > arch/arm/boot/dts/stm32f429.dtsi | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi > index 7de52ee..cbdece7 100644 > --- a/arch/arm/boot/dts/stm32f429.dtsi > +++ b/arch/arm/boot/dts/stm32f429.dtsi > @@ -48,6 +48,7 @@ > #include "skeleton.dtsi" > #include "armv7-m.dtsi" > #include <dt-bindings/pinctrl/stm32f429-pinfunc.h> > +#include <dt-bindings/mfd/stm32f4-rcc.h> > > / { > clocks { > @@ -337,6 +338,16 @@ > slew-rate = <2>; > }; > }; > + > + i2c1_pins_b: i2c1@0 { > + pins1 { > + pinmux = <STM32F429_PB9_FUNC_I2C1_SDA>; > + drive-open-drain; > + }; > + pins2 { > + pinmux = <STM32F429_PB6_FUNC_I2C1_SCL>; > + }; > + }; > }; > > rcc: rcc@40023810 { > @@ -409,6 +420,18 @@ > interrupts = <80>; > clocks = <&rcc 0 38>; > }; > + > + i2c1: i2c@40005400 {
Can you check the order on device node please ? (should follow base@)
> + compatible = "st,stm32f4-i2c"; > + reg = <0x40005400 0x400>; > + interrupts = <31>, > + <32>; > + resets = <&rcc STM32F4_APB1_RESET(I2C1)>; > + clocks = <&rcc 0 STM32F4_APB1_CLOCK(I2C1)>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > }; > }; > >
| |