Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 13 Dec 2016 03:16:05 +0200 | Subject | Re: [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks |
| |
On Tue, Dec 13, 2016 at 2:15 AM, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> wrote: > >>> +#include <linux/platform_data/x86/clk-byt-plt.h> > > > This was a suggestion of Darren Hart in agreement with Thomas Gleixner. > see > http://mailman.alsa-project.org/pipermail/alsa-devel/2016-October/113936.html > > Darren, did we get your proposal right? > >> Is it indeed platform data? I would not create platform_data/x86 >> without strong argument. >> Perhaps include/linux/clk/x86_pmc.h? (Yes, I know about clk-lpss.h >> which is old enough and was basically first try of clk stuff on x86)
Looking more into the patch I got another question. Do we really need a platform driver for that?
That's what I think motivated me for the header location. And that's why I asked about use of the driver/clock provider in the latter patch.
If the answer is yes, then I doubt which location is preferable, otherwise include/clk/x86_*.h looks appropriate.
Sorry if I wasn't clear in the first place.
-- With Best Regards, Andy Shevchenko
| |