lkml.org 
[lkml]   [2016]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers
On Mon, Dec 12, 2016 at 03:28:01PM +0000, Winkler, Tomas wrote:
> >
> > I've tested is completley disjoint from the region pointed by the ACPI device
> > tree (SSDT in PTT's case).
> >
> > Here's example device from my x250:
> >
> > Device (TPM)
> > {
> > Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */) // _HID: Hardware ID
> > Name (_STR, Unicode ("TPM 2.0 Device")) // _STR: Description String Name
> > (CRS, ResourceTemplate () { Memory32Fixed (ReadOnly,
> > 0x00000000, // Address Base
> > 0x00001000, // Address Length
> > _Y00)
>
>
> I'm not sure what is that?
>
> > Memory32Fixed (ReadOnly,
> > 0xFED70000, // Address Base
> > 0x00001000, // Address Length
> > )
>
> But 0xFED70000 should point to CCA

When I implemented originally the driver I followed the MS specification
and used the value from TPM2 ACPI table.

The driver ioremaps 00000000CCDFF000, not the address from SSDT.

> Tomas
> Thanks

/Jarkko

\
 
 \ /
  Last update: 2016-12-12 18:47    [W:3.027 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site