Messages in this thread Patch in this message | | | Subject | Re: Odd build breakage in 4.9-rc7 | From | Paul Bolle <> | Date | Thu, 01 Dec 2016 21:15:31 +0100 |
| |
On Thu, 2016-12-01 at 12:42 -0500, Nicolas Pitre wrote: > OK I understand what the problem is. However most of those hunks below > are definitely wrong. ;-)
Probably. By now I've narrowed it down to just these two hunks:
diff --git a/scripts/Makefile b/scripts/Makefile index 1d80897a9644..f23e5c4f2496 100644 --- a/scripts/Makefile +++ b/scripts/Makefile @@ -40,7 +40,9 @@ build_docproc: $(obj)/docproc build_check-lc_ctype: $(obj)/check-lc_ctype @: -subdir-$(CONFIG_MODVERSIONS) += genksyms +ifeq ($(or $(CONFIG_MODVERSIONS),$(CONFIG_TRIM_UNUSED_KSYMS)),y) +subdir-y += genksyms +endif subdir-y += mod subdir-$(CONFIG_SECURITY_SELINUX) += selinux subdir-$(CONFIG_DTC) += dtc diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh index 8dc1918b6783..7525da1cc2f7 100755 --- a/scripts/adjust_autoksyms.sh +++ b/scripts/adjust_autoksyms.sh @@ -68,7 +68,7 @@ while read sym; do done >> "$new_ksyms_file" # Special case for modversions (see modpost.c) -if [ -n "$CONFIG_MODVERSIONS" ]; then +if [ -n "$CONFIG_MODVERSIONS" -o -n "$CONFIG_TRIM_UNUSED_KSYMS" ]; then echo "#define __KSYM_module_layout 1" >> "$new_ksyms_file" fi > I'm trying to determine the best way to fix it. Stay tuned.
Will do. I'm curious to see what a proper fix might look like.
Thanks,
Paul Bolle
| |