lkml.org 
[lkml]   [2016]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] V4l: omap3isp: Clean up file handle in open() and release().
Date
Hi Shailendra,

Thank you for the patch.

On Thursday 01 Dec 2016 10:15:40 Shailendra Verma wrote:
> Both functions initialize the file handle with v4l2_fh_init()
> and thus need to call clean up with v4l2_fh_exit() as appropriate.
>
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree for v4.11.

> ---
> drivers/media/platform/omap3isp/ispvideo.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/omap3isp/ispvideo.c
> b/drivers/media/platform/omap3isp/ispvideo.c index 7354469..9f966e8 100644
> --- a/drivers/media/platform/omap3isp/ispvideo.c
> +++ b/drivers/media/platform/omap3isp/ispvideo.c
> @@ -1350,6 +1350,7 @@ static int isp_video_open(struct file *file)
> done:
> if (ret < 0) {
> v4l2_fh_del(&handle->vfh);
> + v4l2_fh_exit(&handle->vfh);
> kfree(handle);
> }
>
> @@ -1373,6 +1374,7 @@ static int isp_video_release(struct file *file)
>
> /* Release the file handle. */
> v4l2_fh_del(vfh);
> + v4l2_fh_exit(vfh);
> kfree(handle);
> file->private_data = NULL;

--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2016-12-01 11:29    [W:0.024 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site