Messages in this thread | | | Date | Wed, 9 Nov 2016 18:21:13 -0200 | From | Mauro Carvalho Chehab <> | Subject | Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference |
| |
Em Wed, 9 Nov 2016 11:07:35 -0800 Linus Torvalds <torvalds@linux-foundation.org> escreveu:
> On Wed, Nov 9, 2016 at 3:09 AM, Jörg Otte <jrg.otte@gmail.com> wrote: > > > > Tried patch with no success. Again a NULL ptr dereferece. > > That patch was pure garbage, I think. Pretty much all the other > drivers that use the same approach will have the same issue. Adding > that init function just for the semaphore is crazy. > > I suspect a much simpler approach is to just miove the "data_mutex" > away from the priv area and into "struct dvb_usb_device" and > "dvb_usb_adapter". Sure, that grows those structures a tiny bit, and > not every driver may need that mutex, but it simplifies things > enormously. Mauro?
Yeah, makes sense.
I'll work on moving data_mutex to struct dvb_usb_device.
Thanks, Mauro
| |