Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/2] clk: pxa mark dummy helper as 'inline' | Date | Tue, 08 Nov 2016 23:50:47 +0100 |
| |
On Tuesday, November 8, 2016 2:42:59 PM CET Stephen Boyd wrote: > On 11/08, Arnd Bergmann wrote: > > The dummy_clk_set_parent function is marked as 'static' but is > > no longer referenced from the pxa25x clk driver after the last use > > of the RATE_RO_OPS() macro is gone from this file, causing a > > harmless build warning: > > > > In file included from drivers/clk/pxa/clk-pxa25x.c:24:0: > > drivers/clk/pxa/clk-pxa.h:146:12: error: 'dummy_clk_set_parent' defined but not used [-Werror=unused-function] > > > > This marks the functon as 'inline', which lets the compiler simply > > drop it when it gets referenced. > > > > Fixes: 9fe694295098 ("clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq") > > I hope I don't rewrite clk-next history... I need some sort of > magic git pre-commit hook that rewrites fixes tags if the hash > changes. >
I think if you end up rebasing clk-next, the correct approach would be to fold simple bugfixes into the patches that introduce the problems. Obviously you still need a way to find them though.
Arnd
| |