lkml.org 
[lkml]   [2016]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCHv2 15/49] thermal: core: remove unnecessary device_remove() calls
    Date
    Given that cdevs sysfs properties are already registered using
    the dev.groups, there is no need to explicitly call device_remove()
    for each property.

    Cc: Zhang Rui <rui.zhang@intel.com>
    Cc: linux-pm@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
    ---
    drivers/thermal/thermal_core.c | 5 -----
    1 file changed, 5 deletions(-)

    diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
    index b1d6de9..6100ae7 100644
    --- a/drivers/thermal/thermal_core.c
    +++ b/drivers/thermal/thermal_core.c
    @@ -1876,11 +1876,6 @@ void thermal_cooling_device_unregister(struct thermal_cooling_device *cdev)

    mutex_unlock(&thermal_list_lock);

    - if (cdev->type[0])
    - device_remove_file(&cdev->device, &dev_attr_cdev_type);
    - device_remove_file(&cdev->device, &dev_attr_max_state);
    - device_remove_file(&cdev->device, &dev_attr_cur_state);
    -
    release_idr(&thermal_cdev_idr, &thermal_idr_lock, cdev->id);
    device_unregister(&cdev->device);
    return;
    --
    2.1.4
    \
     
     \ /
      Last update: 2016-11-08 07:19    [W:4.105 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site