Messages in this thread | | | Date | Tue, 8 Nov 2016 17:07:01 +0100 | From | Lukas Wunner <> | Subject | Re: [Nouveau] [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration |
| |
On Tue, Nov 08, 2016 at 04:52:49PM +0100, Arnd Bergmann wrote: > The underlying problem is that we already have a number of other > symbols that either have "depends on LEDS_CLASS" or > "select LEDS_CLASS". To clean that up properly, we should either > make the symbol itself hidden and only select it from other drivers, > or use "depends on LEDS_CLASS" everywhere. > > Another option is to use the IS_REACHABLE() macro instead of IS_ENABLED() > in the header file, to stub out the calls into the new file, but > that can be a bit confusing.
Why don't you just add empty inline stubs for nouveau_led_init / _fini / _suspend / _resume?
Thanks,
Lukas
| |