lkml.org 
[lkml]   [2016]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/11] staging: wlan-ng: fix line style issue in macro WLAN_GET_FC_FSTYPE
    From
    Date
    On Mon, 2016-11-07 at 18:55 +0100, Sergio Paracuellos wrote:
    > This patch fix the following checkpatch.pl script warning:
    > WARNING: line over 80 characters
    >
    > It also add spaces between or operators inside the macro to
    > comply with the standard kernel coding style.
    []
    > diff --git a/drivers/staging/wlan-ng/p80211hdr.h b/drivers/staging/wlan-ng/p80211hdr.h
    []
    > @@ -132,7 +132,8 @@
    > /*------------------------------------------------------------*/
    >
    > #define WLAN_GET_FC_FTYPE(n) ((((u16)(n)) & (BIT(2) | BIT(3))) >> 2)
    > -#define WLAN_GET_FC_FSTYPE(n) ((((u16)(n)) & (BIT(4)|BIT(5)|BIT(6)|BIT(7))) >> 4)
    > +#define WLAN_GET_FC_FSTYPE(n) ((((u16)(n)) & \
    > + (BIT(4) | BIT(5) | BIT(6) | BIT(7))) >> 4)

    Probably better to use GENMASK

    #define WLAN_GET_FC_FTYPE(n) ((((u16)(n)) & GENMASK(3, 2)) >> 2) 
    #define WLAN_GET_FC_FSTYPE(n) ((((u16)(n)) & GENMASK(7, 4)) >> 4)

    \
     
     \ /
      Last update: 2016-11-07 19:59    [W:4.348 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site