lkml.org 
[lkml]   [2016]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] drm: move allocation out of drm_get_format_name()
    From
    Date
    Am 05.11.2016 um 02:33 schrieb Eric Engestrom:
    > +typedef char drm_format_name_buf[32];

    Please don't use a typedef for this, just define the maximum size of
    characters the function might write somewhere.

    See the kernel coding style as well:
    > In general, a pointer, or a struct that has elements that can reasonably
    > be directly accessed should **never** be a typedef.

    Regards,
    Christian.

    \
     
     \ /
      Last update: 2016-11-05 14:45    [W:2.510 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site