Messages in this thread | | | Subject | Re: [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare() | From | Marek Vasut <> | Date | Sat, 5 Nov 2016 08:26:36 +0100 |
| |
On 11/02/2016 06:21 PM, Masahiro Yamada wrote: > The denali_dt_probe() calls clk_disable_unprepare() in the bailout > path, whereas denali_dt_remove calls clk_disable(), inconsistently. > Replace the latter with clk_disable_unprepare() to make sure to > unprepare the clock. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> --- > > drivers/mtd/nand/denali_dt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c > index 0cb1e8d..f821dc1 100644 > --- a/drivers/mtd/nand/denali_dt.c > +++ b/drivers/mtd/nand/denali_dt.c > @@ -110,7 +110,7 @@ static int denali_dt_remove(struct platform_device *ofdev) > struct denali_dt *dt = platform_get_drvdata(ofdev); > > denali_remove(&dt->denali); > - clk_disable(dt->clk); > + clk_disable_unprepare(dt->clk); > > return 0; > } >
-- Best regards, Marek Vasut
| |