| Date | Fri, 4 Nov 2016 15:34:27 +0100 | From | Heiko Carstens <> | Subject | Re: [PATCH 11/25] s390/smp: Convert to hotplug state machine |
| |
On Thu, Nov 03, 2016 at 03:50:07PM +0100, Sebastian Andrzej Siewior wrote: > @@ -1084,20 +1079,13 @@ static int smp_add_present_cpu(int cpu) > rc = sysfs_create_group(&s->kobj, &cpu_common_attr_group); > if (rc) > goto out_cpu; > - if (cpu_online(cpu)) { > - rc = sysfs_create_group(&s->kobj, &cpu_online_attr_group); > - if (rc) > - goto out_online; > - } > + > rc = topology_cpu_init(c);
Please don't add whitespace :)
If you fix the minor nits both s390 related patches are Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Thanks!
|