lkml.org 
[lkml]   [2016]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] usb: host: replace symbolic permission with octal
From
Date
This patch handles warning message for preferring octal
permissions over Symbolic permission for module parameter

Signed-off-by: Amit Kushwaha <kushwaha.a@samsung.com>
---
drivers/usb/host/xhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 1a4ca02..a953d47 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -40,11 +40,11 @@

/* Some 0.95 hardware can't handle the chain bit on a Link TRB being cleared */
static int link_quirk;
-module_param(link_quirk, int, S_IRUGO | S_IWUSR);
+module_param(link_quirk, int, 0644);
MODULE_PARM_DESC(link_quirk, "Don't clear the chain bit on a link TRB");

static unsigned int quirks;
-module_param(quirks, uint, S_IRUGO);
+module_param(quirks, uint, 0444);
MODULE_PARM_DESC(quirks, "Bit flags for quirks to be enabled as default");

/* TODO: copied from ehci-hcd.c - can this be refactored? */
--
2.10.2.windows.1
\
 
 \ /
  Last update: 2016-11-30 14:50    [W:0.082 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site