lkml.org 
[lkml]   [2016]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 17/34] [media] DaVinci-VPFE-Capture: Improve another size determination in vpfe_enum_input()
From
Date
>> @@ -1091,7 +1091,7 @@ static int vpfe_enum_input(struct file *file, void *priv,
>> return -EINVAL;
>> }
>> sdinfo = &vpfe_dev->cfg->sub_devs[subdev];
>> - memcpy(inp, &sdinfo->inputs[index], sizeof(struct v4l2_input));
>> + memcpy(inp, &sdinfo->inputs[index], sizeof(*inp));
>
> If I am not mistaken this can be written as:
>
> *inp = sdinfo->inputs[index];
>
> Much better.

At which position would you like to integrate a second approach for such a change
from this patch series?

* Do you expect me to send a "V2" for the whole series?

* Will an update step be appropriate if I would rebase it on other
recently accepted suggestions?

Regards,
Markus

\
 
 \ /
  Last update: 2016-11-03 22:07    [W:0.117 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site