Messages in this thread | | | Date | Thu, 3 Nov 2016 13:47:49 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH v4] media: et8ek8: add device tree binding documentation |
| |
Hi!
> > +Mandatory properties > > +-------------------- > > + > > +- compatible: "toshiba,et8ek8" > > +- reg: I2C address (0x3e, or an alternative address) > > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts > > +- clocks: External clock to the sensor > > +- clock-frequency: Frequency of the external clock to the sensor. Camera > > + driver will set this frequency on the external clock. > > This is fine if the frequency is fixed (e.g. an oscillator), but you > should use the clock binding if clocks are programable.
It is fixed. So I assume this can stay as is? Or do you want me to add "The clock frequency is a pre-determined frequency known to be suitable to the board." as Sakari suggests?
> > +- reset-gpios: XSHUTDOWN GPIO > > Please state what the active polarity is.
As in "This gpio will be set to 1 when the chip is powered." ?
Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |