Messages in this thread | | | Date | Tue, 29 Nov 2016 21:01:53 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] misc: sram: remove useless #ifdef |
| |
On Tue, Nov 29, 2016 at 08:54:00PM +0100, Alexandre Belloni wrote: > On 29/11/2016 at 20:41:54 +0100, Greg Kroah-Hartman wrote : > > On Tue, Nov 22, 2016 at 03:30:54PM +0100, Arnd Bergmann wrote: > > > A recent patch added a new function that is now unused whenever > > > CONFIG_OF is disabled: > > > > > > drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but not used [-Werror=unused-function] > > > > > > There is actually no reason for the #ifdef, because the driver > > > currently cannot be used in a meaningful way without CONFIG_OF, > > > and there is no compile-time dependency. > > > > > > Removing that #ifdef and the respective of_match_ptr() avoids the > > > warning and simplifies the driver slightly. > > > > > > Fixes: 2ae2e28852f2 ("misc: sram: add Atmel securam support") > > > > What tree is this commit in? I can't seem to find it in one of mine, am > > I just missing it somewhere? > > > > It is in arm-soc (it went through the mach-at91 tree)
Ah, ok, nothing I can do about it then, nice!
| |