lkml.org 
[lkml]   [2016]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 15/22] arm64/cpuinfo: Make hotplug notifier symmetric
From
Date
On 26/11/16 23:13, Sebastian Andrzej Siewior wrote:
> From: Anna-Maria Gleixner <anna-maria@linutronix.de>
>
> There is no requirement to keep the sysfs files around until the CPU is
> completely dead. Remove them during the DOWN_PREPARE notification. This is
> a preparatory patch for converting to the hotplug state machine.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> arch/arm64/kernel/cpuinfo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
> index b3d5b3e8fbcb..19aad7041e14 100644
> --- a/arch/arm64/kernel/cpuinfo.c
> +++ b/arch/arm64/kernel/cpuinfo.c
> @@ -272,9 +272,10 @@ static int cpuid_callback(struct notifier_block *nb,
>
> switch (action & ~CPU_TASKS_FROZEN) {
> case CPU_ONLINE:
> + case CPU_DOWN_FAILED:
> rc = cpuid_add_regs(cpu);
> break;
> - case CPU_DEAD:
> + case CPU_DOWN_PREPARE:
> rc = cpuid_remove_regs(cpu);
> break;
> }

Looks reasonable to me:

Reviewed-by : Suzuki K Poulose <suzuki.poulose@arm.com>

\
 
 \ /
  Last update: 2016-11-29 18:25    [W:0.264 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site