| From | David Howells <> | Subject | Re: [PATCH] Lock down drivers that can have io ports, io mem, irqs and dma changed | Date | Tue, 29 Nov 2016 10:40:03 +0000 |
| |
David Howells <dhowells@redhat.com> wrote:
> It would have to be more like pr_err("Hard-coded device addresses, irqs and > dma channels are not permitted when the kernel is locked down."), possibly > with the addition of either "The driver has been disabled" or "These settings > have been ignored".
That should be "Command line-specified" rather than "Hard-coded". The latter are actually okay.
A better way to do this would probably be to annotate the module parameter declarations and have the module_param() invoker reject the locked-down parameters. I'm not sure how easy that would be to do, though.
David
|