lkml.org 
[lkml]   [2016]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/7] time: alarmtimer: Add the tracepoints for alarmtimer

* Baolin Wang <baolin.wang@linaro.org> wrote:

> On 29 November 2016 at 15:23, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * John Stultz <john.stultz@linaro.org> wrote:
> >
> >> From: Baolin Wang <baolin.wang@linaro.org>
> >>
> >> For system debugging, we sometimes want to know who sets one
> >> alarm timer, the time of the timer, when the timer started and
> >> fired and so on. Thus adding tracepoints can help us trace the
> >> alarmtimer information.
> >
> > s/one alarm timer/an alarm timer
> >
> >> For example, when we debug the system supend/resume, if the
> >> system is always resumed by RTC alarm, we can find out which
> >> process set the alarm timer to resume system by below trace log:
> >
> > s/when we debug the system/when we debug system
> > s/supend/suspend
> > s/resume system/resume the system
> > s/by below trace log/by the trace log below
> >
> >> From the trace log, we can find out the 'Binder:3292_2' process
> >> set one alarm timer which resumes the system.
> >
> > s/set one alarm timer/set an alarm timer
> >
> >> Changes since v4:
> >> - Initialize 'type' to -1 and rename it in alarmtimer_suspend().
> >> - Fix typo in subject line.
> >>
> >> Changes since v3:
> >> - Remove the "ALARM_" prefix in the string.
> >> - Add the ACK by Steven Rostedt.
> >>
> >> Changes since v2:
> >> - Save time as s64 type.
> >> - Remove 'process_name' parameter and add 'now' parameter.
> >> - Rename the trace event name.
> >> - Remove restart trace event.
> >> - Other optimization.
> >
> > I find it really sad that a patch that has gone through 4 iterations still has so
> > many typos and grammar errors in its changelog :-(
>
> Really sorry for these elementary errors, I will fix these errors in
> new patch. Sorry for troubles again.

No problem - the code looks fine to me, so we can fix this when applying the
patches.

Thanks,

Ingo

\
 
 \ /
  Last update: 2016-11-29 10:13    [W:1.090 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site