Messages in this thread Patch in this message | | | From | Jiancheng Xue <> | Subject | [PATCH v2] reset: ti_syscon: fix a ti_syscon_reset_status issue | Date | Wed, 30 Nov 2016 09:03:32 +0800 |
| |
If STATUS_SET was not set, ti_syscon_reset_status would always return 0 no matter whether the status_bit was set or not.
Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com> --- Change Log v2: - Refined this patch according to the suggestion from Andrew F. Davis.
drivers/reset/reset-ti-syscon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c index 47f0ffd..1799fd4 100644 --- a/drivers/reset/reset-ti-syscon.c +++ b/drivers/reset/reset-ti-syscon.c @@ -154,8 +154,8 @@ static int ti_syscon_reset_status(struct reset_controller_dev *rcdev, if (ret) return ret; - return (reset_state & BIT(control->status_bit)) && - (control->flags & STATUS_SET); + return !(reset_state & BIT(control->status_bit)) == + !(control->flags & STATUS_SET); } static struct reset_control_ops ti_syscon_reset_ops = { -- 1.9.1
| |