lkml.org 
[lkml]   [2016]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3 2/4] Documentation/atomic_ops.txt: convert to ReST markup
    Date
    On Sun, 27 Nov 2016, "S. Fricke" <silvio.fricke@gmail.com> wrote:
    > Hi Peter,
    >
    >> On Fri, Nov 25, 2016 at 03:59:45PM +0100, Silvio Fricke wrote:
    >> > ... and move to core-api folder.
    >> >
    >> > Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com>
    >> > ---
    >> > Documentation/atomic_ops.txt => Documentation/core-api/atomic_ops.rst | 777 +++++++++++++++++++++++++++++++++++++-----------------------------------
    >> > Documentation/core-api/index.rst | 1 +-
    >> > Documentation/process/volatile-considered-harmful.rst | 3 +-
    >> > 3 files changed, 404 insertions(+), 377 deletions(-)
    >>
    >> Not a fan of this. The atomic_ops.txt file needs a lot of love, and I
    >> wouldn't want to edit a .rst file.
    >
    > What is the problem with this rst-file? atomic_ops.rst are not so
    > different to the txt variant.

    There is nothing particularly wrong with the patch. Perhaps you could
    leave the tabs in place instead of indenting with spaces in the code
    blocks. It would result in a smaller diff. But other than that, it's
    fine.

    I'm sure Peter is capable of editing a file with a .rst extension, and
    we can clean up any hickups afterwards if getting the formatting right
    is insurmountable.

    > I will drop this patch.

    Please don't. Please let Jon be the judge of that.

    Thanks,
    Jani.


    --
    Jani Nikula, Intel Open Source Technology Center

    \
     
     \ /
      Last update: 2016-11-27 19:37    [W:4.419 / U:0.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site