lkml.org 
[lkml]   [2016]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable
    Date
    > Mark Lord [mailto:mlord@pobox.com]
    > > Sent: Friday, November 25, 2016 12:44 AM
    > [...]
    > > The bad data in this case is ASCII:
    > >
    > > "SRC=m3400:/ TARGET=/m340"
    > >
    > > This data is what is seen in /run/mount/utab, a file that is read/written over NFS
    > on
    > > each boot.
    > >
    > > "SRC=m3400:/ TARGET=/m3400 ROOT=/
    > > ATTRS=nolock,addr=192.168.8.1\n"
    > >
    > > But how does this ASCII data end up at offset zero of the rx buffer??
    > > Not possible -- this isn't even stale data, because only an rx_desc could
    > > be at that offset in that buffer.
    > >
    > > So even if this were a platform memory coherency issue, one should still
    > > never see ASCII data at the beginning of an rx buffer. The driver NEVER
    > > writes anything to the rx buffers. Only the USB hardware ever does.
    > >
    > > And only the r8152 dongle/driver exhibits this issue.
    > > Other USB dongles do not. They *might* still have such issues,
    > > but because they use software checksums, the bad packets are caught/rejected.
    >
    > Do you test it by rebooting? Maybe you could try a patch
    > commit 93fe9b183840 ("r8152: reset the bmu"). However, it should
    > only occur for the first urb buffer after rx is reset. I don't
    > think you would reset the rx frequently, so the situation seems
    > to be different.

    Forgive me. I provide wrong information. This is about RTL8153,
    not RTL8152.

    Best Regards,
    Hayes

    \
     
     \ /
      Last update: 2016-11-25 07:52    [W:4.075 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site