lkml.org 
[lkml]   [2016]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 055/127] coredump: fix unfreezable coredumping task
    Date
    From: Andrey Ryabinin <aryabinin@virtuozzo.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 70d78fe7c8b640b5acfad56ad341985b3810998a upstream.

    It could be not possible to freeze coredumping task when it waits for
    'core_state->startup' completion, because threads are frozen in
    get_signal() before they got a chance to complete 'core_state->startup'.

    Inability to freeze a task during suspend will cause suspend to fail.
    Also CRIU uses cgroup freezer during dump operation. So with an
    unfreezable task the CRIU dump will fail because it waits for a
    transition from 'FREEZING' to 'FROZEN' state which will never happen.

    Use freezer_do_not_count() to tell freezer to ignore coredumping task
    while it waits for core_state->startup completion.

    Link: http://lkml.kernel.org/r/1475225434-3753-1-git-send-email-aryabinin@virtuozzo.com
    Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
    Acked-by: Pavel Machek <pavel@ucw.cz>
    Acked-by: Oleg Nesterov <oleg@redhat.com>
    Cc: Alexander Viro <viro@zeniv.linux.org.uk>
    Cc: Tejun Heo <tj@kernel.org>
    Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
    Cc: Michal Hocko <mhocko@kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    fs/coredump.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/fs/coredump.c b/fs/coredump.c
    index 86753db01f2d..29950247a29a 100644
    --- a/fs/coredump.c
    +++ b/fs/coredump.c
    @@ -1,6 +1,7 @@
    #include <linux/slab.h>
    #include <linux/file.h>
    #include <linux/fdtable.h>
    +#include <linux/freezer.h>
    #include <linux/mm.h>
    #include <linux/stat.h>
    #include <linux/fcntl.h>
    @@ -386,7 +387,9 @@ static int coredump_wait(int exit_code, struct core_state *core_state)
    if (core_waiters > 0) {
    struct core_thread *ptr;

    + freezer_do_not_count();
    wait_for_completion(&core_state->startup);
    + freezer_count();
    /*
    * Wait for all the threads to become inactive, so that
    * all the thread context (extended register state, like
    --
    2.10.2
    \
     
     \ /
      Last update: 2016-11-25 09:59    [W:4.244 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site