lkml.org 
[lkml]   [2016]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH] ARM: dts: Add support for Turris Omnia
    From
    Date
    On 11/23/2016 01:35 AM, Andrew Lunn wrote:
    >> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
    >> @@ -0,0 +1,279 @@
    >> +/*
    >> + * Device Tree file for the Turris Omnia
    >> + * Schematic available at https://www.turris.cz/doc/_media/rtrom01-schema.pdf
    >
    > Cool that there is a link to the schematics. But please could you put
    > it lower down. It is more likely to be seen if it comes after the
    > copyright and license section.

    I added to the top because that's where I would look. But checking other
    dts files it seems indeed to be more common after the copyright stuff.
    I'd suggest to even start a new comment (i.e.

    * last blabla of copyright
    */

    /*
    * Schematic available at ...

    ) to be more "loud".

    @Tomas: I think it doesn't make sense when we alternate sending patches
    without prior arrangement. Do you already work on a v5? If not I can do
    that to fix the last few comments. Not sure when a submission is too
    late to enter v4.10, but I think the window isn't that big any more.

    > No leds? No buttons via gpio-keys?

    The leds are controlled by a Cortex-M0 and without intervention blink
    according to a hardware function (network, power, pci). IMHO that's ok
    for an initial setup.

    And there are no buttons that are routed to the Armada CPU. Just a reset
    button (well, ok, this one is routed to the Armada CPU, but you cannot
    make this a gpio-key :-) and the other button is used to control the
    brightness of the LEDs and is only routed to the M0.

    Best regards
    Uwe

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2016-11-24 09:38    [W:2.244 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site