lkml.org 
[lkml]   [2016]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] powercap/intel_rapl: fix and tidy up error handling
On Wed, Nov 23, 2016 at 8:01 PM, Jacob Pan
<jacob.jun.pan@linux.intel.com> wrote:
> Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added
> contraint_to_pl() function to return index into an array. But it
> can potentially return -EINVAL if powercap layer sends an out of
> range constraint ID. This patch adds sanity check.
>
> Unnecessary RAPL domain pointer check is removed since it must be
> initialized before calling rapl_unit_xlate().
>
> Reported-by: Odzioba, Lukasz <lukasz.odzioba@intel.com>
> Reported-by: Koss, Marcin <marcin.koss@intel.com>

Does this depend on the Thomas' series only?

Also, it looks like a Fixes: tag should be present here.

>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

Thanks,
Rafael

\
 
 \ /
  Last update: 2016-11-24 22:08    [W:0.044 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site