lkml.org 
[lkml]   [2016]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable
    From
    From: Mark Lord <mlord@pobox.com>
    Date: Thu, 24 Nov 2016 07:31:17 -0500

    > Any way we look at it though, the chip/driver are simply unreliable,
    > and relying upon hardware checksums (which fail due to the driver
    > looking at garbage rather than the checksum bits) leads to data
    > corruption.

    If the cpu/DMA implementation is the problem, then turning off
    checksums is not an appropriate fix at all.

    In fact, we have no idea what the cause is yet.

    That makes turning off random features no more than grasping at straws
    and makes no sense at all upstream.

    It may make sense for you to do such a change locally in _your_ tree
    to fix your situation temporarily. But upstream we shouldn't be doing
    it.

    \
     
     \ /
      Last update: 2016-11-24 17:28    [W:3.516 / U:0.972 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site