lkml.org 
[lkml]   [2016]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.8 55/67] IB/mlx4: Fix create CQ error flow
    Date
    4.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Matan Barak <matanb@mellanox.com>

    commit 593ff73bcfdc79f79a8a0df55504f75ad3e5d1a9 upstream.

    Currently, if ib_copy_to_udata fails, the CQ
    won't be deleted from the radix tree and the HW (HW2SW).

    Fixes: 225c7b1feef1 ('IB/mlx4: Add a driver Mellanox ConnectX InfiniBand adapters')
    Signed-off-by: Matan Barak <matanb@mellanox.com>
    Signed-off-by: Daniel Jurgens <danielj@mellanox.com>
    Reviewed-by: Mark Bloch <markb@mellanox.com>
    Signed-off-by: Leon Romanovsky <leon@kernel.org>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/hw/mlx4/cq.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/infiniband/hw/mlx4/cq.c
    +++ b/drivers/infiniband/hw/mlx4/cq.c
    @@ -253,11 +253,14 @@ struct ib_cq *mlx4_ib_create_cq(struct i
    if (context)
    if (ib_copy_to_udata(udata, &cq->mcq.cqn, sizeof (__u32))) {
    err = -EFAULT;
    - goto err_dbmap;
    + goto err_cq_free;
    }

    return &cq->ibcq;

    +err_cq_free:
    + mlx4_cq_free(dev->dev, &cq->mcq);
    +
    err_dbmap:
    if (context)
    mlx4_ib_db_unmap_user(to_mucontext(context), &cq->db);

    \
     
     \ /
      Last update: 2016-11-24 16:33    [W:4.217 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site