lkml.org 
[lkml]   [2016]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.8 12/67] mfd: intel-lpss: Do not put device in reset state on suspend
    Date
    4.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Azhar Shaikh <azhar.shaikh@intel.com>

    commit 274e43edcda6f709aa67e436b3123e45a6270923 upstream.

    Commit 41a3da2b8e163 ("mfd: intel-lpss: Save register context on
    suspend") saved the register context while going to suspend and
    also put the device in reset state.

    Due to the resetting of device, system cannot enter S3/S0ix
    states when no_console_suspend flag is enabled. The system
    and serial console both hang. The resetting of device is not
    needed while going to suspend. Hence remove this code.

    Fixes: 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend")
    Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
    Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mfd/intel-lpss.c | 3 ---
    1 file changed, 3 deletions(-)

    --- a/drivers/mfd/intel-lpss.c
    +++ b/drivers/mfd/intel-lpss.c
    @@ -502,9 +502,6 @@ int intel_lpss_suspend(struct device *de
    for (i = 0; i < LPSS_PRIV_REG_COUNT; i++)
    lpss->priv_ctx[i] = readl(lpss->priv + i * 4);

    - /* Put the device into reset state */
    - writel(0, lpss->priv + LPSS_PRIV_RESETS);
    -
    return 0;
    }
    EXPORT_SYMBOL_GPL(intel_lpss_suspend);

    \
     
     \ /
      Last update: 2016-11-24 16:29    [W:4.150 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site