Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 24 Nov 2016 15:17:36 +0100 | Subject | Re: [PATCH RESEND 2/2] gpio: axp209: add pinctrl support |
| |
On Wed, Nov 23, 2016 at 3:11 PM, Quentin Schulz <quentin.schulz@free-electrons.com> wrote:
> The GPIOs present in the AXP209 PMIC have multiple functions. They > typically allow a pin to be used as GPIO input or output and can also be > used as ADC or regulator for example.[1] > > This adds the possibility to use all functions of the GPIOs present in > the AXP209 PMIC thanks to pinctrl subsystem. > > [1] see registers 90H, 92H and 93H at > http://dl.linux-sunxi.org/AXP/AXP209_Datasheet_v1.0en.pdf > > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
I need Maxime's review on this patch.
> .../devicetree/bindings/gpio/gpio-axp209.txt | 28 +-
Also move the bindings to pinctrl/pinctrl-axp209.txt
> drivers/gpio/gpio-axp209.c | 551 ++++++++++++++++++---
Combined drivers should be in drivers/pinctrl/*.
Make a separate patch moving the driver to drivers/pinctrl/pinctrl-axp209.c (remember -M to git format-patch) augment Kconfig and Makefile in both subsystems and make these patches on top of that.
I will deal with cross-merging the result between the GPIO and pin control trees.
Yours, Linus Walleij
| |