lkml.org 
[lkml]   [2016]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: xhci: Remove unuseful 'return' statement
From
Date
Hello.

On 11/24/2016 11:13 AM, Baolin Wang wrote:

> Since these 'return' statements are not generally useful in void function,
> remove them.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
[...]
> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
> index 48a26d378..d6f59a3 100644
> --- a/drivers/usb/host/xhci-mem.c
> +++ b/drivers/usb/host/xhci-mem.c
> @@ -1146,7 +1146,6 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd *xhci, struct usb_device *ud
> case USB_SPEED_WIRELESS:
> xhci_dbg(xhci, "FIXME xHCI doesn't support wireless speeds\n");
> return -EINVAL;
> - break;

Here you're removing *break* instead but not mentioning this in the patch
description...

[...]

MBR, Sergei

\
 
 \ /
  Last update: 2016-11-24 10:30    [W:0.668 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site