Messages in this thread | | | From | Kuninori Morimoto <> | Subject | Re: [alsa-devel] [PATCH v2] clkdev: add devm_of_clk_get() | Date | Thu, 24 Nov 2016 01:45:53 +0000 |
| |
Hi Stephen
Thank you for your feedback
> I've seen bindings that have the 'clocks' property at the top > level and the appropriate 'clock-names' property to relate the > clocks to a subnode. > > sound_soc { > clocks = <&xxx>, <&xxx>; > clock-names = "cpu", "codec"; > ... > cpu { > ... > }; > codec { > ... > }; > }; > > Then the subnodes call clk_get() with the top level device and > the name of their node and things match up. I suppose this > binding is finalized though, so we can't really do that? > > I see that the gpio framework has a similar design called > devm_get_gpiod_from_child(), so how about we add a > devm_get_clk_from_child() API? That would more closely match the > intent here, which is to restrict the clk_get() operation to > child nodes of the device passed as the first argument. > > struct clk *devm_get_clk_from_child(struct device *dev, > const char *con_id, > struct device_node *child);
Thanks. I will check above 2 ideas.
Best regards --- Kuninori Morimoto
| |