lkml.org 
[lkml]   [2016]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: iio: adc: fix sysfs files modes in ad7192.c
On Tue, Nov 22, 2016 at 11:25:14PM -0800, Boyan Vladinov wrote:
> Fixes sysfs entries user/group modes and coding style warnings
> found by checkpatch.pl tool
>
> Signed-off-by: Boyan Vladinov <nayobix@nayobix.org>
> ---
> drivers/staging/iio/adc/ad7192.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 1fb68c01abd5..3f9f54b654f7 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -341,10 +341,10 @@ ad7192_show_scale_available(struct device *dev,
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> - in_voltage-voltage_scale_available,
> - S_IRUGO, ad7192_show_scale_available, NULL, 0);
> + in_voltage - voltage_scale_available,
> + 0444, ad7192_show_scale_available, NULL, 0);

IIO_DEVICE_ATTR_RO() after fixing up some variable names?

>
> -static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
> +static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
> ad7192_show_scale_available, NULL, 0);

IIO_DEVICE_ATTR_RO()?

>
> static ssize_t ad7192_show_ac_excitation(struct device *dev,
> @@ -412,11 +412,11 @@ static ssize_t ad7192_set(struct device *dev,
> return ret ? ret : len;
> }
>
> -static IIO_DEVICE_ATTR(bridge_switch_en, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(bridge_switch_en, 0444 | 0200,
> ad7192_show_bridge_switch, ad7192_set,
> AD7192_REG_GPOCON);

IIO_DEVICE_ATTR_RW()?

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-11-23 08:38    [W:0.361 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site