Messages in this thread | | | Date | Wed, 23 Nov 2016 13:42:19 +0000 | From | Mark Rutland <> | Subject | Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] |
| |
On Wed, Nov 23, 2016 at 11:25:57AM +0000, David Howells wrote: > Mark Rutland <mark.rutland@arm.com> wrote: > > > int secure_boot = efi_get_secureboot(sys_table); > > > > if (secure_boot > 0) > > pr_efi(sys_table, "UEFI Secure Boot is enabled.\n"); > > if (secure_boot < 0) > > pr_efi_err(sys_table, > > "could not determine UEFI Secure Boot status.\n"); > > In which case, should this be moved into efi_get_secureboot() and it return a > bool?
That would make sense to me, provided we're only likely to call that once (and only log once).
I guess it would also make sense to change the latter case to soemthing like: Could not determine UEFI Secure Boot status. Assuming enabled.
... so as to make it clear what the effect is.
Thanks, Mark.
| |