Messages in this thread | | | Subject | Re: [PATCH] Staging: iio: adc: fix sysfs files modes in ad7192.c | From | Joe Perches <> | Date | Wed, 23 Nov 2016 03:33:12 -0800 |
| |
On Tue, 2016-11-22 at 23:25 -0800, Boyan Vladinov wrote: > Fixes sysfs entries user/group modes and coding style warnings > found by checkpatch.pl tool [] > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c [] > static ssize_t ad7192_show_ac_excitation(struct device *dev, > @@ -412,11 +412,11 @@ static ssize_t ad7192_set(struct device *dev, > return ret ? ret : len; > } > > -static IIO_DEVICE_ATTR(bridge_switch_en, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(bridge_switch_en, 0444 | 0200,
If you are going to submit S_<FOO> -> octal conversions, please collapse the multiple octal values into one value
0444 | 0200 => 0644
| |